Bump engine to api 37#186930
Conversation
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
| # See tools/gradle/README.md for update instructions. | ||
| # Version here means the CIPD tag. | ||
| 'version': 'version:8.11.1', | ||
| 'version': 'version:9.4.1', |
There was a problem hiding this comment.
@jesswrd I think you had thoughts on what this value should or should not be.
| } | ||
| dependencies { | ||
| classpath "com.android.tools.build:gradle:8.11.1" | ||
| classpath "com.android.tools.build:gradle:9.2.1" |
There was a problem hiding this comment.
Why does this version not match the version you added in deps?
There was a problem hiding this comment.
Why does this version not match the version you added in deps?
Seems like a typo, i will fix it after i'm back
There was a problem hiding this comment.
FYI @reidbaker, i checked again this is the used AGP version not the gradle version, if i did bump the compilesdk to 37, i get:
We recommend using a newer Android Gradle plugin to use compileSdk = 37
This Android Gradle plugin (8.9.1) was tested up to compileSdk = 36.
You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 37.
If you are already using the latest version of the Android Gradle plugin,
you may need to wait until a newer version with support for compileSdk = 37 is available.
which would require
classpath "com.android.tools.build:gradle:9.2.1"
and a gradle version of at least 9.4.1
which means these are correct values
|
sdk 37 is uploaded to cipd (It was uploaded last week but I forgot to tag you) |
|
@reidbaker i think i also need gradle 9.4.1 because i see in logs: |
Lets not update gradle that far as part of this work. |
|
I'm switching to another task, you can ignore the tasks related to this, @reidbaker thanks for the time and sorry i can't finish this one. |
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.