[code_assets] Fix multi architecture framework naming#185640
Merged
auto-submit[bot] merged 2 commits intoApr 28, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the fatAssetTargetLocations function to track asset name conflicts per target architecture using a map, preventing naming collisions across different architectures. New unit tests have been added to verify cross-architecture isolation and conflict resolution within the same architecture. Feedback includes a suggestion to simplify map initialization using the ??= operator, a recommendation to sort assets by ID to ensure deterministic naming results, and the removal of an unused import in the test file.
liamappelbe
approved these changes
Apr 27, 2026
bkonyi
approved these changes
Apr 28, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: dart-lang/native#3319
The framework renaming was renaming assets of different architectures uniquely, but the renaming should be per architecture because they are combined in a framework.