Add pr filter for waiting for response label in a11y pr triage#185441
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the triage documentation by adding a filter to exclude pull requests labeled 'waiting for response' from various team-specific search queries. Feedback was provided to clean up the URLs by replacing double plus signs with single separators to avoid redundant spaces in the search parameters.
|
We should not unilaterally change the triage flow of every other team; I would want to keep an eye on these PRs in ecosystem triage, for instance. This should either have a reviewer from every affected team, or should be done separately by each team who wants to do it. |
|
sounds good, I will update this to target accessibility team only instead |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@stuartmorgan-g updated to only for a11y team. PTAL |
There was a problem hiding this comment.
Code Review
This pull request updates the triage documentation for the Accessibility team by adding a filter to exclude PRs with a specific label from the query list. Feedback indicates that the label name used is likely incorrect and should be 'waiting for customer response' to match repository standards. Additionally, it was suggested to apply this filter consistently across all teams listed in the document to ensure a uniform triage process.
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
Since now we have the label, we can filter out pr with the waiting... label during triage
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.