[CP-beta]Only use LLDB breakpoint in debug mode#185343
Conversation
The JIT breakpoint workaround is only needed and only enabled on the Dart side in debug mode. When running `--profile` mode, the breakpoint is never set and therefore causes the process to hang. This PR skips the JIT breakpoint workaround for profile mode. Fixes flutter#185150. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
@vashworth please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request updates the iOS LLDB attachment logic to distinguish between debug and profile build modes. The IOSCoreDeviceLauncher and LLDB classes now require a BuildMode parameter, which is used to conditionally set breakpoints and match specific log patterns during process resumption. The changes include updates to the device start logic and expanded test coverage. A review comment suggests adding missing assertions to the new profile mode test to ensure consistent verification across build modes.
| expect(success, isTrue); | ||
| expect(lldb.isRunning, isTrue); |
There was a problem hiding this comment.
The new test for profile mode is missing several assertions that were added to the debug mode test above. Adding these will ensure that the correct LLDB commands are sent, the process ID is correctly tracked, and no errors occurred during the attachment process.
| expect(success, isTrue); | |
| expect(lldb.isRunning, isTrue); | |
| expect(success, isTrue); | |
| expect(lldb.isRunning, isTrue); | |
| expect(lldb.appProcessId, appProcessId); | |
| expect(expectedInputs, isEmpty); | |
| expect(processManager.hasRemainingExpectations, isFalse); | |
| expect(logger.errorText, isEmpty); |
justinmc
left a comment
There was a problem hiding this comment.
CPLGTM 👍 . Apologies that I missed this PR earlier in the week, it will likely not be released until next week.
298a428
into
flutter:flutter-3.44-candidate.0
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#185150
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.
Deploying to a physical iOS device in profile mode with Xcode 26 will hang.
Changelog Description:
Explain this cherry pick:
See best practices for examples.
< Replace with changelog description here >
[flutter/185150] When using profile mode on a physical iOS device, the app may fail to connect to the Dart VM.
Workaround:
Is there a workaround for this issue?
Disable LLDB debuggin (
flutter config --no-enable-lldb-debugging) or run through XcodeRisk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Run one of these tests: #185150 (comment)