Fix SemanticsObject crash when bridge is nullptr#185293
Merged
auto-submit[bot] merged 6 commits intoApr 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces safety checks in SemanticsObject to verify the accessibility bridge's status before accessing its view or calculating frames, preventing potential crashes when the bridge is no longer available. A corresponding unit test was added to validate these changes. Feedback was provided regarding a memory leak in the new test case where a mock bridge is allocated using 'new' but never deallocated.
LouiseHsu
approved these changes
Apr 27, 2026
LouiseHsu
left a comment
Contributor
There was a problem hiding this comment.
google testing is super failing but otherwise the changes lgtm
Contributor
Author
|
Let me try google-testing again |
This was referenced Apr 29, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #174853 (I have not verified myself but the bridge availability check should prevent the potential null dereference).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.