Make the welcome message output to stderr if --machine#184819
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces an isMachine property to the Logger interface and its implementations to distinguish between human-readable and machine-readable output. The MachineOutputLogger is updated to set this property to true. The Usage.printWelcome method is modified to direct license terms to stderr when the logger is identified as machine-oriented, and to stdout otherwise. Corresponding tests have been added to verify this behavior. A review comment suggests using globals.logger.printStatus for consistency in the else block of the printWelcome method.
| logFunction(messenger.licenseTerms, emphasis: true); | ||
| _printedWelcome = true; |
There was a problem hiding this comment.
For consistency with the if block, which uses globals.logger directly, it would be clearer to also use globals.logger.printStatus here instead of the globals.printStatus shorthand.
globals.logger.printStatus('');
globals.logger.printStatus(messenger.licenseTerms, emphasis: true);
Fixes #54014.