Remove semantics_tester import from cupertino/slider_test.dart#184805
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Slider Semantics test in packages/flutter/test/cupertino/slider_test.dart by replacing SemanticsTester with tester.ensureSemantics() and matchesSemantics. The changes include removing the SemanticsTester import, updating the semantics handle management, and refining the expectation logic to use tester.getSemantics on the CupertinoSlider. I have no feedback to provide.
|
Pushed a formatter-only follow-up (a77d30a) to address the Linux analyze/format failure. Local checks now pass:
The remaining red check is the Material/Cupertino code-freeze guard because this PR touches |
|
The remaining failing check is the Material/Cupertino code-freeze guard because this PR touches packages/flutter/test/cupertino/**. I do not have permission to add labels on flutter/flutter; could a maintainer please add the label if this semantics-test-only cleanup should land during the freeze? |
|
The remaining failing check is the Material/Cupertino code-freeze guard because this PR touches packages/flutter/test/cupertino/**. I do not have permission to add labels on flutter/flutter; could a maintainer please add the |
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Thanks for migrating TestSemantics the right way. I will add the freeze override.
|
autosubmit label was removed for flutter/flutter/184805, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
|
autosubmit label was removed for flutter/flutter/184805, because - The status or check suite Check Code Freeze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/184805, because - The status or check suite Check Code Freeze has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
Hi @justinmc @navaronbracke — CI is all green and this PR is approved. Could you please merge or add the |
Part of #182636
Summary
Remove the
semantics_tester.dartcross-import fromcupertino/slider_test.dart.What changed
SemanticsTester/TestSemanticsassertion in the slider semantics test withtester.getSemantics(...)andmatchesSemantics(...)../widgets/semantics_tester.dartimportTesting
../../bin/flutter analyze test/cupertino/slider_test.dart../../bin/flutter test test/cupertino/slider_test.dart