Set path_provider_android version#184688
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the path_provider_android dependency to the widget preview scaffold and updates the package tests to include it. Feedback suggests sorting dependencies alphabetically in pubspec.yaml for consistency and notes that the method of injecting dependencies in tests is brittle. Additionally, the PR description and pre-launch checklist must be completed to comply with the repository's style guide.
|
autosubmit label was removed for flutter/flutter/184688, because - The status or check suite Mac tool_integration_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
I've temporarily unpublished 2.3.0 as a fast out-of-band way to fix the issues. We can still land this though, if we want to control the roll back to 2.3.0 in flutter/flutter rather than it being another OOB change when I re-publish it. |
This didn't actually fix it so it's unclear to me where/why 2.3.0 was causing it to break. @stuartmorgan-g Do you think if was you un-publishing that fixed the tree or #184695? It seemed like #184695 would fix one test but not the widget previewer failures |
|
flutter/flutter already seemed to be green again this morning before I unpublished, so #184695 looks like it was all we needed.
That PR fixed the tool itself (to not assert for a valid configuration), so it should fix that failure in any test that hit it. |
Pin
path_provider_androidto 2.2.23 while #184689 is being investigated.Also update the top-level pins so it's not upgraded anywhere else.
Also ran
flutter update-packages --force-upgrade --update-hashesto confirmpath_provider_androidwas pinned.Note #182627 will move widget_preview_scaffold into the pub workspace, so it won't have its own separate pin.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.