[iOS] Make it easier to run unit tests from CLI#184617
Merged
auto-submit[bot] merged 2 commits intoApr 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates error messages in engine/src/flutter/testing/run_tests.py to provide clearer instructions for build failures. The changes include formatting improvements to the error strings and adjusting the assertion in the main function to adhere to line length guidelines. I recommend simplifying the construction of the final_message string to improve readability and applying the suggested line break for the assertion in the main function to comply with the 80-character limit.
hellohuanlin
previously approved these changes
Apr 5, 2026
hellohuanlin
left a comment
Contributor
There was a problem hiding this comment.
Gemini's suggestion seems to be reasonable.
hellohuanlin
approved these changes
Apr 6, 2026
4155f7b to
9d864a4
Compare
Contributor
|
looks like you got your review but im just here to say YESSSSSSS |
9d864a4 to
903307c
Compare
11885a7 to
0acdf11
Compare
0acdf11 to
ae41755
Compare
Member
Author
|
Holy moly, google test please have mercy 😭😭😭😭 |
This was referenced Apr 25, 2026
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can use
run_tests.pyto run iOS unit tests from the command line. This script assumes you built theios_debug_sim_unoptvariant. This improves the error messages if you built a different variant, likeios_debug_sim_unopt_arm64.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.