Increase size of checkbox, switch, and radio button to 48 by 48#18337
Increase size of checkbox, switch, and radio button to 48 by 48#18337jonahwilliams wants to merge 1 commit into
Conversation
…nform to android a11y scanner
|
This is a breaking change, so i will go through the normal process before submitting |
|
This will only increase the hit box, right? Not the visual appearance of the checkbox/switch/radio button? Might be worth to be specific in the title for future archeologists. |
| inactiveColor: inactiveColor, | ||
| onChanged: onChanged, | ||
| size: const Size(2 * kRadialReactionRadius, 2 * kRadialReactionRadius), | ||
| size: const Size(2 * kRadialReactionRadius + 8.0, 2 * kRadialReactionRadius + 8.0), |
There was a problem hiding this comment.
Is there value in maybe adding a comment to explain where the 8.0 is coming from here and in other places?
There was a problem hiding this comment.
The + 8.0 serves to increase the radius from 20 to 24. We should not increase the radius from 20 to 24.
|
This will change the layout size of checkbox et al, which we should really not change. Aside from being a backwards incompatible change, it undoes #17620 which was landed to make the sizes of the selection controls, and the widgets that contain them, match the spec. We need to find a way to just increase the size of the hit test area. |
|
Closing in favor of #18369 |
Conform to android a11y scanner and 48 by 48 tap target recommendation.