-
Notifications
You must be signed in to change notification settings - Fork 30.6k
[widgets/raw_menu_anchor.dart] Always call onClose and onCloseRequested on descendants before parent. #182357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidhicks980
merged 21 commits into
flutter:master
from
davidhicks980:raw_menu_anchor_close_order
Apr 7, 2026
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b5eb1d7
Add fix to menu anchor
davidhicks980 41e7787
Add regression text
davidhicks980 8a7f896
Remove unnecessary closeChildren calls.
davidhicks980 d209ca4
Add async test and an additional comment reminding users to cancel th…
davidhicks980 33a0c8e
Merge branch 'master' into raw_menu_anchor_close_order
davidhicks980 40bf127
Implement Tong suggestions
davidhicks980 47ba4db
Flip request close sequence
davidhicks980 6709c9e
short circuit close requests if menu is already closed.
davidhicks980 3221cf2
Merge branch 'master' into raw_menu_anchor_close_order
davidhicks980 c34e489
parent => sibling
davidhicks980 8781e8c
parent => sibling
davidhicks980 f7037be
Elaborate on disabling interactivity
davidhicks980 abf169b
Clarify comments
davidhicks980 8ce071c
remove comma
davidhicks980 97c9c47
Merge branch 'master' into raw_menu_anchor_close_order
davidhicks980 cc314fe
Merge branch 'master' into raw_menu_anchor_close_order
davidhicks980 96d2393
Tong suggestions
davidhicks980 0d7b8f6
Tong changes slightly modified
davidhicks980 15716d9
Merge branch 'master' into raw_menu_anchor_close_order
davidhicks980 9e088c6
Merge branch 'master' into raw_menu_anchor_close_order
dkwingsmt 193ed58
Merge branch 'master' into raw_menu_anchor_close_order
dkwingsmt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a see also to reference closeChildrenWithRequest and vice versa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done