Relands "[cupertino.dart] Implement CupertinoMenuAnchor and Cupertino…#182103
Closed
chunhtai wants to merge 2 commits into
Closed
Relands "[cupertino.dart] Implement CupertinoMenuAnchor and Cupertino…#182103chunhtai wants to merge 2 commits into
chunhtai wants to merge 2 commits into
Conversation
…upertinoMenuItem using RawMenuAnchor (flutter#174695)" (flutter#182010)" This reverts commit fa51de9.
Contributor
Author
|
failure |
Contributor
Author
|
The issue is that the _SwipeRegionState dispose doesn't dispose the gesture immediately, looking at the code it relies on the gesture to finish to delay the disposal, and that seems like a code smell, because it will attempt to call widget callback after the widget is disposed. so i change it to dispose immediately The unit test that fails when a test teardown without calling the gesture cancel which causes surface the bug. The change is in the second commit |
Contributor
Author
Contributor
|
Thanks for you attempt, although @davidhicks980 has drafted a reland #182036 . Would you like to take a look? |
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…MenuItem using RawMenuAnchor (#174695)"
This reverts commit fa51de9.
previous pr failed post commit
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8690627764525514545/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.