Skip to content

Remove material import from opacity_test.dart#180506

Closed
alex-medinsh wants to merge 3 commits into
flutter:masterfrom
alex-medinsh:opacity-remove-material-import
Closed

Remove material import from opacity_test.dart#180506
alex-medinsh wants to merge 3 commits into
flutter:masterfrom
alex-medinsh:opacity-remove-material-import

Conversation

@alex-medinsh

@alex-medinsh alex-medinsh commented Jan 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Towards #177415

Replaces the convenient MaterialApp and Scaffold for a ColoredBox.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 5, 2026
@alex-medinsh alex-medinsh force-pushed the opacity-remove-material-import branch from 8962a75 to 95cbe3a Compare January 5, 2026 11:19
@alex-medinsh alex-medinsh marked this pull request as ready for review January 5, 2026 13:15
@victorsanni victorsanni requested a review from justinmc January 5, 2026 18:39
@rkishan516

rkishan516 commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Hey @alex-medinsh, I think opacity tests are already covered in #180456.

@justinmc justinmc mentioned this pull request Jan 14, 2026
Open
@justinmc

justinmc commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

That's right, sorry @alex-medinsh. I've now added a note under MaterialApp in the issue #177415 to try to avoid this happening again, and I'll try to keep that up to date.

This PR should be closed when #180456 merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc Awaiting requested review from justinmc

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

Test cross-imports Review Queue
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alex-medinsh @rkishan516 @justinmc @Piinks