Skip to content

Add regression test for Slider inside TableRow #180342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
divyanshyagyik wants to merge 3 commits into from
Closed

Add regression test for Slider inside TableRow #180342

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f62d6f
Add regression test for Slider inside TableRow
divyanshyagyik Dec 27, 2025
724aee6
Fix formatting in Slider/Table regression test
divyanshyagyik Dec 27, 2025
55f9bd8
Merge branch 'master' into slider-table-regression-test
divyanshyagyik Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/flutter/test/widgets/table_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,24 @@ void main() {
'Every TableRow in a Table must have at least one child, so there is no empty row.',
);
});

// Regression test for https://github.com/flutter/flutter/issues/180337.
// Verifies that placing a Slider (which uses OverlayPortal) inside a TableRow
// does not trigger a render object ownership assertion.
testWidgets('Table widget - Slider inside TableRow does not crash', (WidgetTester tester) async {
await tester.pumpWidget(
const MaterialApp(
home: Scaffold(
body: Table(
children: <TableRow>[
TableRow(children: <Widget>[Slider(value: 0.0, onChanged: null)]),
],
),
),
),
);
await tester.pumpAndSettle();
expect(tester.takeException(), isNull);
Comment on lines +933 to +934

@justinmc justinmc Jan 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two lines are unnecessary.

});
testWidgets('Set defaultVerticalAlignment to intrinsic height and check their heights', (
WidgetTester tester,
) async {
Expand Down