Fix misleading error message for color/decoration conflict #180325
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request improves the developer experience by fixing misleading error messages in CupertinoSearchTextField and Container. The previous assert messages were contradictory, and the new messages clearly explain that one property is a shorthand for another. This change is well-aligned with the Flutter style guide's emphasis on useful error messages. The implementation is correct and consistent. I have reviewed the changes and found no issues.
|
LGTM, though there are merge conflicts. @nathannewyen are you able to resolve them? |
|
Closing this PR - the issue has already been fixed upstream in #178823 with a more complete error message. Thanks for the review @MitchellGoodwin! |
|
Thanks for the review @MitchellGoodwin! While resolving the conflicts, I noticed this issue was already fixed upstream in #178823 with a more complete error message. Closing this PR as it's now redundant. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
The error message said 'To provide both' which contradicts 'Cannot provide both'. Updated to match the clearer wording used in Ink and AnimatedContainer widgets. Fixes flutter#119484
1b3f44b to
5db27c4
Compare
|
Resolved the merge conflict. Apologies for the confusion earlier - I incorrectly closed the PR thinking the issue was already fixed. The conflict has been resolved by accepting the upstream changes. |
Description
Fixes the contradictory error message that says "Cannot provide both... To provide both".
Updated wording to match
InkandAnimatedContainerwidgets which use clearer phrasing.Related Issue
Fixes #119484