[flutter_tools] Pass --chrome-binary to app hosting Chrome in flutter drive #179935
Conversation
… drive Fixes flutter#171504 The --chrome-binary flag was only being passed to WebDriver Chrome, not to the app hosting Chrome instance. This change passes the flag through DebuggingOptions so both Chrome instances use the specified binary. Changes: - Add webChromeBinary field to DebuggingOptions - Pass chromeBinary parameter to ChromiumLauncher.launch() - Forward webChromeBinary in WebDriverService.start() - Add test for custom chrome binary path
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature that allows users to specify a custom path for the Chrome executable when running Flutter web applications. The changes involve adding a webChromeBinary parameter to the DebuggingOptions class and its constructors, propagating this parameter through the createDebuggingOptions method in RunCommandBase, and enabling the flutter drive command to accept a --chrome-binary argument. The ChromiumLauncher is updated to use the provided custom binary path if available, otherwise falling back to its default browser discovery. A new test case has been added to verify the functionality of launching Chrome with a custom binary path. No review comments were provided.
Update TestChromiumLauncher.launch() method signature in test files to include the chromeBinary parameter added to ChromiumLauncher.launch()
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bkonyi
left a comment
There was a problem hiding this comment.
LGTM!
However, it looks like packages/flutter_tools/test/web.shard/chrome_test.dart needs to be formatted.
Fixes #171504
Problem
When running
flutter drive -d chrome --chrome-binary=/path/to/chrome, the--chrome-binaryflag was only being passed to WebDriver Chrome, not to the app hosting Chrome instance.Solution
Added
webChromeBinaryfield toDebuggingOptionsand passed it through toChromiumLauncher.launch().Changes
webChromeBinaryfield toDebuggingOptionschromeBinaryparameter toChromiumLauncher.launch()webChromeBinaryinWebDriverService.start()Test
Verified that log shows
Will use Chromium executable at /custom/path/chrome.