Restore the ListTile layout updates #17661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
approved these changes
May 16, 2018
Contributor
|
|
Hixie
reviewed
May 25, 2018
| } | ||
|
|
||
| static double _boxBaseline(RenderBox box) { | ||
| return box.getDistanceToBaseline(TextBaseline.alphabetic); |
Contributor
There was a problem hiding this comment.
this should not hard-code the baseline.
Hixie
reviewed
May 25, 2018
| double computeDistanceToActualBaseline(TextBaseline baseline) { | ||
| assert(title != null); | ||
| final BoxParentData parentData = title.parentData; | ||
| return parentData.offset.dy + title.getDistanceToBaseline(TextBaseline.alphabetic); |
Contributor
There was a problem hiding this comment.
this should not hard-code the baseline.
Also, and more importantly, this should use getDistanceToActualBaseline rather than getDistanceToBaseline.
Contributor
There was a problem hiding this comment.
i'll submit a PR to fix this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the ListTile layout changes that were reverted:
#17496
#17580
The original PRs introduced a
RadioListTilelayout problem that has been fixed:#17620