Run skwasm framework unit tests on a single shard. #175001
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Greetings from stale PR triage! 👋 |
Contributor
|
Welcome back to stale PR triage - do you have plans to move this change forward? |
Contributor
Author
|
I think Mouad already did some consolidation of these, so this can just be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts all the skwasm framework unit tests onto a single shard. The time taken to run the actual tests on each shard was roughly 90-180 seconds, so a large portion of the work done on each shard was just setup/teardown. I'm trying this to see if they might all just fit on a single shard, like the VM unit tests do.