Skip to content

Conversation

@srawlins
Copy link
Contributor

@srawlins srawlins commented May 9, 2018

This is required to comply with the new noSuchMethod forwarding semantics coming from Dart soon. dart-lang/sdk#33031

It also bumps csslib *shwew*! And appears to remove need for barback and cli_util. Wins all around!

@srawlins
Copy link
Contributor Author

srawlins commented May 9, 2018

@jonahwilliams do you know why isolate deps would be disagreeing with themselves? I just ran ./bin/flutter update-packages --force-upgrade. 😁

@jonahwilliams
Copy link
Contributor

@srawlins I'm not sure why specifically, but I do recall someone else having an issue with the isolate dep.

@jonahwilliams
Copy link
Contributor

apparently the analyzer had a dependency on isolate until recently

@srawlins
Copy link
Contributor Author

srawlins commented May 9, 2018

Anything I can do or like... not?

@jonahwilliams
Copy link
Contributor

cc @devoncarew

@devoncarew
Copy link
Contributor

Hmm, package:analyzer removed its dep (which was I believe in 1.1.0). That should make version resolution easier. I'd look to see which packages here still have a dep on isolate.

@srawlins
Copy link
Contributor Author

Only two direct dependencies

$ find . -name pubspec.yaml -exec grep isolate {} \; -print
  isolate: 2.0.0
./examples/stocks/pubspec.yaml
  isolate: 2.0.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
./dev/benchmarks/microbenchmarks/pubspec.yaml

@srawlins
Copy link
Contributor Author

OK I think I found something. This bumps the version of test to 0.12.37, which has a transitive dependency on isolate ^1.1.0.

The test package depends on the analyzer package. The latest analyzer, 0.31.1 depends on isolate >=0.2.2 <2.0.0.

@srawlins
Copy link
Contributor Author

Opened a bug for @jonahwilliams or... whomever. #17473.

@devoncarew
Copy link
Contributor

@srawlins, I'm going to look at changing how we depend on package:analyzer (after my analysis PR we no longer need the version from the sdk). That may indirectly help this PR out...

@devoncarew
Copy link
Contributor

devoncarew commented May 10, 2018

@srawlins, you should be good to go. You'll have some merge conflicts :) You may want to re-apply the mockito change in a new PR.

@srawlins
Copy link
Contributor Author

lol yeah its not easy recovering from these merges. I'll probably open a new PR in a bit.

@srawlins srawlins closed this May 10, 2018
@srawlins srawlins deleted the bump-mockito-alhpha-5 branch May 10, 2018 21:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants