Add java as a dependency of linux analyze since it is required by ktlint #173982
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly identifies the need to add Java as a dependency for the linux_analyze CI target, which is required by ktlint. However, the implementation introduces a syntax error in .ci.yaml by omitting a comma between elements in a JSON array, which will cause CI failures. I've also noted a minor inconsistency in the dependency version formatting that could be improved for clarity.
| dependencies: >- | ||
| [ | ||
| {"dependency": "ktlint", "version": "version_1_5_0"} | ||
| {"dependency": "open_jdk", "version": "version:21"} |
There was a problem hiding this comment.
The version format version:21 is inconsistent with the format used for the ktlint dependency (version_1_5_0). To improve maintainability, please ensure the version string conforms to the expected format for CIPD packages in this configuration.
|
Potentially an tooling issue not a configuration issue #173986 |
I did not find documentation for which java version was required but we use Java 21 for many tests and it passed locally for me with java 17 and 24
https://github.com/pinterest/ktlint/releases
#173869 (comment)
A rerun fixed this issue which indicates some of our bots happen to have java and some do not.
Pre-launch Checklist
///).