Yea, i'm hoping to work with Jonah when he gets back to come up with a fix. Right now I just want to unblock work on playgrounds.

autosubmit label was removed for flutter/flutter/167360, because - The status or check suite Windows windows_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

You shouldn't land a change that has a (large) performance impact on production applications to work a round a bug in a non-production system (imgui playground component).

That's the protocol we follow, if a PR is blocking development it is reverted. I think we all agree that ideally this would have been blocked from landing by CI. We should come up with a fix when you are back in town but in the meantime we shouldn't be impeding development on the main branch.

do not revert this PR.

The problem with addressing this is that TextureVK is caching a vk::RenderPass. That texture will be used for a regular rendering with a depth buffer. When we use it with imgui the render texture will not have that and so the vk::RenderPass will be invalid.

Options as I see it:

1. Make caching renderpasses be a combination of f(texture, render_target) instead of just f(texture).
2. Pass contextual information about the fact we are using imgui to avoid using the render pass cache in that case.

@jonahwilliams says the underlying bug is fixed.