[Flutter GPU] WIP: Fix Android/GLES bugs. #165630
Conversation
| ? std::move(cached_program) | ||
| : std::make_shared<UniqueHandleGLES>(UniqueHandleGLES::MakeUntracked( | ||
| reactor, HandleType::kProgram)))); | ||
| : std::make_shared<UniqueHandleGLES>(reactor, HandleType::kProgram))); |
There was a problem hiding this comment.
WIP. This needs a new endpoint. Pushing in current state to test the end-to-end test on CI.
There was a problem hiding this comment.
Which endpoint is needed ? Can I implement it? Can you give more information about it ?
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
sorry,When will this draft be merged? I'm in a hurry to use it. |
|
Closing for now as this PR is stale. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Can you give mor information about functionality of endpoint that needed to finish this pull request ? I am very excited to help |
|
We too are interested in this fix. We are investigating Flutter as an alternative to Qt and require Flutter GPU. It's impossible to make progress given how frequently this crash happens. It's also concerning to us how long this bug has been allowed to stick around given how serious it is. Is this a common thing in Flutter? |
I noticed that @jonahwilliams doing some pull requests, I don't know why @bdero didn't finish. However I really can not understand what endpoint needed to finish. I can do some engine stuff but without context it is very difficult . I think we will wait Mr Jonah W. |
Resolves #164278.
Resolves bdero/flutter_scene#35.
Resolves bdero/flutter_scene#39.
Partly fixes: #160948.
And add an
android_engine_testscenario.