Skip to content

Remove --verbose from devicelab task executions. #162644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Feb 7, 2025
Merged

Remove --verbose from devicelab task executions. #162644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feaaefe
Remove --verbose from devicelab task executions.
matanlurey Feb 4, 2025
794a0d2
Merge branch 'master' into remove-verbose-device-lab-tasks
matanlurey Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dev/devicelab/bin/tasks/android_obfuscate_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ Future<void> main() async {
'--target-platform=android-arm',
'--obfuscate',
'--split-debug-info=foo/',
'--verbose',
],
);
});
Expand Down Expand Up @@ -67,7 +66,6 @@ Future<void> main() async {
'--split-debug-info=foo/',
'--no-debug',
'--no-profile',
'--verbose',
],
);
});
Expand Down
2 changes: 1 addition & 1 deletion dev/devicelab/bin/tasks/build_aar_module_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Future<void> main() async {
section('Build release AAR');

await inDirectory(projectDir, () async {
await flutter('build', options: <String>['aar', '--verbose']);
Copy link
Contributor

@reidbaker reidbaker Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider keeping this one. If an aar fails to build then I think verbose logs might be required to know why.

Copy link
Contributor Author

@matanlurey matanlurey Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect if it's important we can add it back 🤷🏼

await flutter('build', options: <String>['aar']);
});

final String repoPath = path.join(projectDir.path, 'build', 'host', 'outputs', 'repo');
Expand Down
2 changes: 0 additions & 2 deletions dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ Future<void> _testBuildIosFramework(Directory projectDir, {bool isModule = false
'build',
options: <String>[
'ios-framework',
'--verbose',
'--output=$outputDirectoryName',
'--obfuscate',
'--split-debug-info=symbols',
Expand Down Expand Up @@ -470,7 +469,6 @@ Future<void> _testBuildMacOSFramework(Directory projectDir) async {
'build',
options: <String>[
'macos-framework',
'--verbose',
'--output=$outputDirectoryName',
'--obfuscate',
'--split-debug-info=symbols',
Expand Down
2 changes: 1 addition & 1 deletion dev/devicelab/bin/tasks/flutter_gallery_v2_chrome_run_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class NewGalleryChromeRunTest {

await flutter('build', options: <String>['web', '-v', '--release', '--no-pub']);

final List<String> options = <String>['-d', 'chrome', '--verbose', '--resident'];
final List<String> options = <String>['-d', 'chrome', '--resident'];
final Process process = await startFlutter('run', options: options);

final Completer<void> stdoutDone = Completer<void>();
Expand Down
10 changes: 2 additions & 8 deletions dev/devicelab/bin/tasks/gradle_plugin_bundle_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,7 @@ Future<void> main() async {
section('Build app bundle using the flutter tool - flavor: flavor_underscore');

int exitCode = await inDirectory(project.rootPath, () {
return flutter(
'build',
options: <String>['appbundle', '--flavor=flavor_underscore', '--verbose'],
);
return flutter('build', options: <String>['appbundle', '--flavor=flavor_underscore']);
});

if (exitCode != 0) {
Expand Down Expand Up @@ -108,10 +105,7 @@ Future<void> main() async {
section('Build app bundle using the flutter tool - flavor: production');

exitCode = await inDirectory(project.rootPath, () {
return flutter(
'build',
options: <String>['appbundle', '--flavor=production', '--verbose'],
);
return flutter('build', options: <String>['appbundle', '--flavor=production']);
});

if (exitCode != 0) {
Expand Down
14 changes: 4 additions & 10 deletions dev/devicelab/bin/tasks/gradle_plugin_fat_apk_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Future<void> main() async {
await runPluginProjectTest((FlutterPluginProject pluginProject) async {
section('APK content for task assembleDebug without explicit target platform');
await inDirectory(pluginProject.exampleAndroidPath, () {
return flutter('build', options: <String>['apk', '--debug', '--verbose']);
return flutter('build', options: <String>['apk', '--debug']);
});

Iterable<String> apkFiles = await getFilesInApk(pluginProject.debugApkPath);
Expand All @@ -42,7 +42,7 @@ Future<void> main() async {
section('APK content for task assembleRelease without explicit target platform');

await inDirectory(pluginProject.exampleAndroidPath, () {
return flutter('build', options: <String>['apk', '--release', '--verbose']);
return flutter('build', options: <String>['apk', '--release']);
});

apkFiles = await getFilesInApk(pluginProject.releaseApkPath);
Expand All @@ -67,12 +67,7 @@ Future<void> main() async {
await inDirectory(pluginProject.exampleAndroidPath, () {
return flutter(
'build',
options: <String>[
'apk',
'--release',
'--verbose',
'--target-platform=android-arm,android-arm64',
],
options: <String>['apk', '--release', '--target-platform=android-arm,android-arm64'],
);
});

Expand Down Expand Up @@ -100,7 +95,6 @@ Future<void> main() async {
options: <String>[
'apk',
'--release',
'--verbose',
'--split-per-abi',
'--target-platform=android-arm,android-arm64',
],
Expand Down Expand Up @@ -136,7 +130,7 @@ Future<void> main() async {
section('gradlew assembleRelease');

await inDirectory(project.rootPath, () {
return flutter('build', options: <String>['apk', '--release', '--verbose']);
return flutter('build', options: <String>['apk', '--release']);
});

// When the platform-target isn't specified, we generate the snapshots
Expand Down
2 changes: 1 addition & 1 deletion dev/devicelab/bin/tasks/hello_world__memory.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class HelloWorldMemoryTest extends MemoryTest {
print('launching $project$test on device...');
await flutter(
'run',
options: <String>['--verbose', '--release', '--no-resident', '-d', device!.deviceId, test],
options: <String>['--release', '--no-resident', '-d', device!.deviceId, test],
);
await Future<void>.delayed(const Duration(milliseconds: 1500));
await recordStart();
Expand Down
2 changes: 1 addition & 1 deletion dev/devicelab/bin/tasks/ios_app_with_extensions_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Future<void> main() async {
await inDirectory(projectDir, () async {
final String buildOutput = await evalFlutter(
'build',
options: <String>['ios', '--no-codesign', '--release', '--verbose'],
options: <String>['ios', '--no-codesign', '--release'],
);
if (!buildOutput.contains('-destination generic/platform=watchOS')) {
print(buildOutput);
Expand Down
4 changes: 2 additions & 2 deletions dev/devicelab/bin/tasks/module_test_ios.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ dependencies:
section('Build ephemeral host app in release mode without CocoaPods');

await inDirectory(projectDir, () async {
await flutter('build', options: <String>['ios', '--no-codesign', '--verbose']);
await flutter('build', options: <String>['ios', '--no-codesign']);
});

// Check the tool is no longer copying to the legacy xcframework location.
Expand Down Expand Up @@ -606,7 +606,7 @@ end
);

if (!xcodebuildOutput.contains(
'flutter --verbose --local-engine-src-path=bogus assemble',
RegExp('flutter.*--local-engine-src-path=bogus assemble'),
) || // Verbose output
!xcodebuildOutput.contains(
'Unable to detect a Flutter engine build directory in bogus',
Expand Down
2 changes: 1 addition & 1 deletion dev/devicelab/bin/tasks/plugin_dependencies_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ public class DummyPluginAClass {
section('Build plugin A example iOS app');

await inDirectory(exampleApp, () async {
await evalFlutter('build', options: <String>['ios', '--no-codesign', '--verbose']);
await evalFlutter('build', options: <String>['ios', '--no-codesign']);
});

final Directory appBundle = Directory(
Expand Down
36 changes: 6 additions & 30 deletions dev/devicelab/bin/tasks/plugin_lint_mac.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,21 +37,15 @@ Future<void> main() async {
'integration_test.podspec',
);

await exec('pod', <String>[
'lib',
'lint',
iosintegrationTestPodspec,
'--use-libraries',
'--verbose',
]);
await exec('pod', <String>['lib', 'lint', iosintegrationTestPodspec, '--use-libraries']);

final String macosintegrationTestPodspec = path.join(
integrationTestPackage,
'integration_test_macos',
'macos',
'integration_test_macos.podspec',
);
await _tryMacOSLint(macosintegrationTestPodspec, <String>['--verbose']);
await _tryMacOSLint(macosintegrationTestPodspec, <String>[]);
});

section('Create Objective-C plugin');
Expand All @@ -76,13 +70,7 @@ Future<void> main() async {
final String objcPluginPath = path.join(tempDir.path, objcPluginName);
final String objcPodspecPath = path.join(objcPluginPath, 'ios', '$objcPluginName.podspec');
await inDirectory(tempDir, () async {
await exec('pod', <String>[
'lib',
'lint',
objcPodspecPath,
'--allow-warnings',
'--verbose',
]);
await exec('pod', <String>['lib', 'lint', objcPodspecPath, '--allow-warnings']);
});

section('Lint Objective-C iOS podspec plugin as library');
Expand All @@ -94,7 +82,6 @@ Future<void> main() async {
objcPodspecPath,
'--allow-warnings',
'--use-libraries',
'--verbose',
]);
});

Expand All @@ -120,13 +107,7 @@ Future<void> main() async {
final String swiftPluginPath = path.join(tempDir.path, swiftPluginName);
final String swiftPodspecPath = path.join(swiftPluginPath, 'ios', '$swiftPluginName.podspec');
await inDirectory(tempDir, () async {
await exec('pod', <String>[
'lib',
'lint',
swiftPodspecPath,
'--allow-warnings',
'--verbose',
]);
await exec('pod', <String>['lib', 'lint', swiftPodspecPath, '--allow-warnings']);
});

section('Lint Swift iOS podspec plugin as library');
Expand All @@ -138,7 +119,6 @@ Future<void> main() async {
swiftPodspecPath,
'--allow-warnings',
'--use-libraries',
'--verbose',
]);
});

Expand All @@ -150,17 +130,13 @@ Future<void> main() async {
'$swiftPluginName.podspec',
);
await inDirectory(tempDir, () async {
await _tryMacOSLint(macOSPodspecPath, <String>['--allow-warnings', '--verbose']);
await _tryMacOSLint(macOSPodspecPath, <String>['--allow-warnings']);
});

section('Lint Swift macOS podspec plugin as library');

await inDirectory(tempDir, () async {
await _tryMacOSLint(macOSPodspecPath, <String>[
'--allow-warnings',
'--use-libraries',
'--verbose',
]);
await _tryMacOSLint(macOSPodspecPath, <String>['--allow-warnings', '--use-libraries']);
});

section('Create Objective-C application');
Expand Down
9 changes: 1 addition & 8 deletions dev/devicelab/bin/tasks/route_test_ios.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,7 @@ void main() {
await inDirectory(appDir, () async {
return flutter(
'drive',
options: <String>[
'--verbose',
'-d',
device.deviceId,
'--route',
'/smuggle-it',
'lib/route.dart',
],
options: <String>['-d', device.deviceId, '--route', '/smuggle-it', 'lib/route.dart'],
);
});
return TaskResult.success(null);
Expand Down
10 changes: 1 addition & 9 deletions dev/devicelab/bin/tasks/routing_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,7 @@ void main() {
await inDirectory(appDir, () async {
return flutter(
'drive',
options: <String>[
'--verbose',
'-d',
device.deviceId,
'--route',
'/smuggle-it',
'lib/route.dart',
],
options: <String>['-d', device.deviceId, '--route', '/smuggle-it', 'lib/route.dart'],
);
});
section('TEST WHETHER `flutter run --route` WORKS');
Expand All @@ -42,7 +35,6 @@ void main() {
'run',
// --fast-start does not support routes.
options: <String>[
'--verbose',
'--disable-service-auth-codes',
'--no-fast-start',
'--no-publish-port',
Expand Down
1 change: 0 additions & 1 deletion dev/devicelab/bin/tasks/service_extensions_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ void main() {
final Process run = await startFlutter(
'run',
options: <String>[
'--verbose',
'--no-fast-start',
'--no-publish-port',
'--disable-service-auth-codes',
Expand Down