TappableLabel extension type
#158465
Closed
TappableLabel extension type
#158465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is pending #158466 |
4ab2c26 to
1a470ea
Compare
nate-thegrate
commented
Jan 30, 2025
Comment on lines
-615
to
+600
| final CustomPaint dialPaint = tester.widget(findDialPaint); | ||
| final dynamic dialPainter = dialPaint.painter; | ||
| // ignore: avoid_dynamic_calls | ||
| final List<dynamic> primaryLabels = dialPainter.primaryLabels as List<dynamic>; | ||
| expect( | ||
| // ignore: avoid_dynamic_calls | ||
| primaryLabels.map<String>((dynamic tp) => tp.painter.text.text as String), | ||
| labels12To11, | ||
| ); | ||
| final List<TappableLabel> primary, selected; | ||
| (:primary, :selected) = TappableLabel.labels(tester.widget(findDialPaint)); | ||
|
|
||
| // ignore: avoid_dynamic_calls | ||
| final List<dynamic> selectedLabels = dialPainter.selectedLabels as List<dynamic>; | ||
| expect( | ||
| // ignore: avoid_dynamic_calls | ||
| selectedLabels.map<String>((dynamic tp) => tp.painter.text.text as String), | ||
| labels12To11, | ||
| ); | ||
| expect(primary.map<String?>((TappableLabel tp) => tp.textSpan?.text), labels12To11); | ||
| expect(selected.map<String?>((TappableLabel tp) => tp.textSpan?.text), labels12To11); |
Contributor
Author
There was a problem hiding this comment.
Even if we don't land this, it was still fun to do 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a type interface and removes
// ignorecomments from tests.Before
After