Skip to content

[CP] Fix flutter upgrade failing with "Unknown Flutter tag" to 3.14 #133821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyHillers merged 1 commit into from
Sep 1, 2023
Merged

[CP] Fix flutter upgrade failing with "Unknown Flutter tag" to 3.14 #133821

CaseyHillers merged 1 commit into from
Sep 1, 2023
+45 −11

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Aug 31, 2023 •
edited
Loading

Fixes flutter upgrade which would fail with "Unknown flutter tag" because it would call git commands in the user's current working directory instead of the Flutter SDK.

Fixes #133822

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. a: desktop Running on desktop labels Aug 31, 2023
@christopherfujino christopherfujino mentioned this pull request Aug 31, 2023
Closed
@christopherfujino christopherfujino changed the base branch from master to flutter-3.14-candidate.0 August 31, 2023 23:43
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 31, 2023

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino christopherfujino marked this pull request as ready for review August 31, 2023 23:43
@itsjustkevin itsjustkevin removed a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. a: desktop Running on desktop labels Sep 1, 2023
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 1, 2023

auto label is removed for flutter/flutter/133821, due to - The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-commands-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-general-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 1, 2023

auto label is removed for flutter/flutter/133821, due to - The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-commands-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-general-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 1, 2023

@CaseyHillers looks like we might have to manually merge this one?

@CaseyHillers CaseyHillers merged commit 544a652 into flutter:flutter-3.14-candidate.0 Sep 1, 2023
@christopherfujino christopherfujino deleted the cherrypicks-flutter-3.14-candidate.0 branch September 1, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CP] Fix flutter upgrade failing with "Unknown Flutter tag" on beta 3.14

5 participants

@christopherfujino @zanderso @CaseyHillers @itsjustkevin @godofredoc