Revert "[flutter_tools] cache flutter sdk version to disk" #129130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3246808.
CaseyHillers
approved these changes
Jun 19, 2023
jason-simmons
requested changes
Jun 19, 2023
Member
jason-simmons
left a comment
There was a problem hiding this comment.
This test suite was failing because of a new random ordering seed.
See #129131
Contributor
Author
|
This failure was fixed forward in #129131. The revert is not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #124558
This causes a reproducible failure of packages/flutter_tools/test/commands.shard/permeable/upgrade_test.dart.
The failure of
'UpgradeCommandRunner fetchLatestVersion returns version if git succeeds'
with a failing null check in
#0 UpgradeCommandRunner.fetchLatestVersion (package:flutter_tools/src/commands/upgrade.dart:301:36)
disappears if the commit is reverted.