Skip to content

Conversation

@fluttergithubbot
Copy link
Contributor

This PR was generated by flutter update-packages --force-upgrade.

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. autosubmit Merge PR when tree becomes green via auto submit App labels May 16, 2023
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. team: flakes c: tech-debt Technical debt, code quality, testing, etc. labels May 16, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 16, 2023

auto label is removed for flutter/flutter, pr: 126966, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 2 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@github-actions github-actions bot added a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: integration_test The flutter/packages/integration_test plugin labels May 16, 2023
@christopherfujino
Copy link
Contributor

@natebosch there are 1878 analysis failures across the repo (none in flutter_tools though): https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8780898069202916497/+/u/Analyze/analyze/test_stdout

Was test v1.24.3 expected to be this breaking?

@natebosch
Copy link
Contributor

No, package:test was not breaking. package:test_api had some breaking changes which may have translated into flutter_test having breaking changes.

I cannot find where the matchers are exported from flutter_test - I don't see any exports of package:test_api/test_api.dart which could have been where they came from before but wouldn't be exported anymore.

@natebosch
Copy link
Contributor

The APIs which appear to be missing should be getting exported from flutter_test from their definition in package:matcher.

export 'package:matcher/expect.dart' hide expect, isInstanceOf;

@natebosch
Copy link
Contributor

natebosch commented May 18, 2023

I see an error Target of URI doesn't exist: 'package:matcher/expect.dart'.

This PR does bump matcher to 0.12.16 which includes this library - are the analysis failures using that version of matcher?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks off - matcher should remain a dependency of flutter_test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, good catch. I guess flutter_test now needs to directly depend on it, rather than transitively via test_api.

@christopherfujino christopherfujino force-pushed the packages-autoroller-branch-107 branch from 6341cb3 to e8210ef Compare May 19, 2023 00:11
@christopherfujino
Copy link
Contributor

Ok, now the problem seems to be a conflict in customer_testing with apps that depend on mockito:

| Because mockito >=5.0.1 <5.0.6 depends on test_api >=0.2.1 <0.4.0 and mockito >=5.0.6 <5.4.0 depends on test_api >=0.2.1 <0.5.0, mockito >=5.0.1 <5.4.0 requires test_api >=0.2.1 <0.5.0.
| And because mockito >=5.4.0 depends on test_api >=0.2.1 <0.6.0 and every version of flutter_test from sdk depends on test_api 0.6.0, flutter_test from sdk is incompatible with mockito >=5.0.1.
| So, because super_editor depends on both flutter_test from sdk and mockito ^5.0.4, version solving failed.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8780714514063702145/+/u/Customer_testing/customer_testing/test_stdout

Given because mockito >=5.4.0 depends on test_api >=0.2.1 <0.6.0 I'm guessing dart-lang/mockito@34da8da needs to be published? @natebosch

@natebosch
Copy link
Contributor

I'm guessing dart-lang/mockito@34da8da needs to be published? @natebosch

Published in version 5.4.1. https://pub.dev/packages/mockito/versions/5.4.1

@christopherfujino
Copy link
Contributor

I'm guessing dart-lang/mockito@34da8da needs to be published? @natebosch

Published in version 5.4.1. https://pub.dev/packages/mockito/versions/5.4.1

nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants