Skip to content

CP: Use packages/packages recipe. (#122822) #122844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godofredoc merged 1 commit into from
Mar 17, 2023
Merged

CP: Use packages/packages recipe. (#122822) #122844

godofredoc merged 1 commit into from
Mar 17, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 16, 2023

CP: 9f35ed7

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use packages/packages recipe. (#122822)
af5663b 
Use packages/packages recipe.
@godofredoc godofredoc requested a review from keyonghan as a code owner March 16, 2023 23:02
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 16, 2023

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

XilaiZhang
XilaiZhang approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@godofredoc
Copy link
Contributor Author

godofredoc commented Mar 17, 2023

Landing with failures, they are not related to this CP.

@godofredoc godofredoc merged commit c3882b0 into flutter:flutter-3.9-candidate.1 Mar 17, 2023
@godofredoc godofredoc deleted the flutter-3.9-candidate.1 branch March 17, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

+1 more reviewer

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @XilaiZhang @fluttergithubbot