Add --serve-observatory flag to run, attach, and test #118402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag will allow for Observatory to be served by the VM service once it is disabled by default in the Dart SDK.
Contributor
Author
|
Observatory won't be disabled by default until after the FYI @zanderso |
| return _testFile('flutter_gold', automatedTestsDirectory, flutterTestDirectory, exitCode: isZero); | ||
| }); | ||
|
|
||
| testWithoutContext('flutter test should respect --serve-observatory', () async { |
Contributor
There was a problem hiding this comment.
Would any of these tests fail without your change, or would they all pass because the Dart SDK defaults to serving the observatory?
Contributor
Author
There was a problem hiding this comment.
I've written them in such a way that they should all pass now since Observatory is currently served by default, yes.
zanderso
reviewed
Jan 12, 2023
zanderso
reviewed
Jan 13, 2023
Contributor
Author
|
Friendly bump :) |
zanderso
reviewed
Jan 17, 2023
zanderso
reviewed
Jan 18, 2023
packages/flutter_tools/test/general.shard/resident_runner_test.dart
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Friendly bump |
--serve-observatory flag to run, attach, and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag will allow for Observatory to be served by the VM service once it is disabled by default in the Dart SDK.