Extract snapshotting logic to Snapshotter class #11820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract a Snapshotter class that can be shared between FLX snapshotting, AOT snapshotting, and assembly AOT snapshotting. Allows for better testability of snapshotting logic. * Extracts script snapshotting used in FLX build. * Adds tests for snapshot checksumming, build invalidation/skipping. Remaining work: disentangle + extract AOT snapshotting and Assembly AOT snapshotting logic from build_aot.dart.
goderbauer
reviewed
Aug 29, 2017
| /// Dart snapshot builder. | ||
| /// | ||
| /// Builds Dart snapshots in one of three modes: | ||
| /// * Script snapshot: architecture-independent snapshot of a Dart script core |
Member
There was a problem hiding this comment.
this seems to switch between singular and plural mid-sentence?
goderbauer
reviewed
Aug 29, 2017
|
|
||
| // Compute and record checksums. | ||
| try { | ||
| final Set<String> snapshotInputPaths = await readDepfile(dependencies) |
Member
There was a problem hiding this comment.
(I can't add a comment to the appropriate lines in this file)
Maybe add a todo in this file where gen_snapshot is referenced to indicate that this should be using the new snapshotter instead?
This was referenced Sep 1, 2017
Hixie
reviewed
May 30, 2018
| '--isolate_snapshot_data=$isolateSnapshotData', | ||
| '--packages=$packagesPath', | ||
| '--dependencies=$depfilePath', | ||
| '--print_snapshot_sizes', |
Contributor
There was a problem hiding this comment.
can we remove this --print option? It adds spurious output when running flutter run --release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract snapshotting logic to Snapshotter class
Extract a Snapshotter class that can be shared between FLX snapshotting,
AOT snapshotting, and assembly AOT snapshotting. Allows for better
testability of snapshotting logic.
Remaining work: disentangle + extract AOT snapshotting and Assembly AOT
snapshotting logic from build_aot.dart.