[conductor] update post-release builder links #117360
Closed
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XilaiZhang
approved these changes
Dec 20, 2022
Contributor
|
auto label is removed for flutter/flutter, pr: 117360, due to - The status or check suite Mac_ios hot_mode_dev_cycle_macos_target__benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label. |
godofredoc
reviewed
Dec 20, 2022
Contributor
There was a problem hiding this comment.
This one and the flutter one may need to stay the same for now. Dart-internal will have the engine dashboards only after the migration to recipes v2.
Contributor
Author
There was a problem hiding this comment.
We monitor engine tests through cocoon, do we need to be monitoring at the luci level also?
Contributor
There was a problem hiding this comment.
Suggested change
| String luciConsoleLink(String channel, String groupName) { | |
| String luciConsoleLink(String channel, String groupName) { | |
| assert( | |
| globals.kReleaseChannels.contains(channel), | |
| 'channel $channel not recognized', | |
| ); | |
| assert( | |
| <String>['flutter', 'engine', 'packaging'].contains(groupName), | |
| 'group named $groupName not recognized', | |
| ); | |
| final String consoleName = | |
| channel == 'master' ? groupName : '${channel}_$groupName'; | |
| if (groupName == 'packaging') { | |
| return 'https://luci-milo.appspot.com/p/dart-internal/g/flutter_packaging/console'' | |
| } | |
| return 'https://ci.chromium.org/p/flutter/g/$consoleName/console'; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates conductor instructions to point to the new console link.