Update IntegrationTestPlugin.m #116539
Update IntegrationTestPlugin.m #116539
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
pdblasi-google
left a comment
There was a problem hiding this comment.
LGTM
@barringb Thanks for the PR and the great write-up! The links and history provided some much needed context, so I really appreciate it!
There was a problem hiding this comment.
This does not appear to be an issue with
integration_testand my tests exit properly regardless of run withflutter driveor through XCode.
You tested this with static libraries (the default with an Objective-C project)?
integration_testwas migrated frome2eto prevent an error where thee2eplugin would not exit testing.
I'm not sure how that would have fixed this issue. I need to check out this change and see if I can reproduce #48601
|
I tried to get the hang to reproduce and couldn't, details in #91668 (comment) Instead of this one line change, let's actually remove the entire workaround from flutter/plugins#2465. Meaning remove the exposed + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
FlutterMethodChannel *channel = [FlutterMethodChannel methodChannelWithName:kIntegrationTestPluginChannel
binaryMessenger:registrar.messenger];
[registrar addMethodCallDelegate:[self instance] channel:channel];
}Let me know if you would prefer I close this and open my own PR instead. |
jmagman
left a comment
There was a problem hiding this comment.
Requesting -setupChannels: removal.
|
(Triage) @barringb Do you still have plans to follow-up on the feedback given above? Thanks! |
|
I wound up reverting flutter/plugins#2465 in #123729, including removing the now-dead code. @barringb Thank you for your contribution and kicking off this investigation! |
The integration_test native plugin is not being correctly registered on iOS when running tests via
flutter drive. Adding anIntegrationTestPlugininstance toregisterWithRegistrarmethod inIntegrationTestPlugin.m.This plugin instance was previously removed before
integration_testwas migrated frome2eto prevent an error where thee2eplugin would not exit testing. This does not appear to be an issue withintegration_testand my tests exit properly regardless of run withflutter driveor through XCode.List which issues are fixed by this PR. You must list at least one issue.
#91668
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.