Skip to content

Make tear-offs cacheable for RenderSemanticsGestureHandler #11556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 3 commits into from
Aug 8, 2017
Merged

Make tear-offs cacheable for RenderSemanticsGestureHandler #11556

goderbauer merged 3 commits into from
Aug 8, 2017

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Aug 8, 2017 •
edited
Loading

Fixes #11552.

@goderbauer goderbauer changed the title Fix tear off Make tear-offs cachable for RenderSemanticsGestureHandler Aug 8, 2017
Hixie
Hixie reviewed Aug 8, 2017
View reviewed changes
packages/flutter/lib/src/widgets/gesture_detector.dart Outdated
Copy link
Contributor

@Hixie Hixie Aug 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have this call _updateHandlers directly? Having it bounce through updateRenderObject is weird.

Copy link
Member Author

@goderbauer goderbauer Aug 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Changed.

@Hixie
Copy link
Contributor

Hixie commented Aug 8, 2017

LGTM

@goderbauer goderbauer changed the title Make tear-offs cachable for RenderSemanticsGestureHandler Make tear-offs cacheable for RenderSemanticsGestureHandler Aug 8, 2017
@goderbauer goderbauer merged commit 3b76e7e into flutter:master Aug 8, 2017
@goderbauer goderbauer deleted the fixTearOff branch August 8, 2017 22:46
@goderbauer goderbauer added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Oct 17, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Hixie left review comments

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Caching callbacks in RenderSemanticsGestureHandler doesn't work as expected

3 participants

@goderbauer @Hixie @googlebot