gradlew/gradlew.bat should not be gitignored according to official doc#109750
Closed
fzyzcjy wants to merge 1 commit into
Closed
gradlew/gradlew.bat should not be gitignored according to official doc#109750fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
This is the repo's gitignore, not a template file gitignore. |
Contributor
Author
|
I know. The problem is, maybe flutter repo itself also need to follow gradle's official suggestion? |
Contributor
|
We've done this historically because the tool can handle re-generating this and to avoid churn in the repo when the contents of this file changes. |
Contributor
|
I'm going to close this PR, as we don't intend to accept this change. If something changes we can always reconsider |
Contributor
Author
|
I see. Thanks all the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #109749
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.