Provide common interface for gestures that provide position#101665
Provide common interface for gestures that provide position#101665mateusfccp wants to merge 2 commits into
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I don't know if this kind of change is test-exempt, I can't think of any tests that could be added, as it's a simple change in the type system... |
|
I am not super-convinced of the benefits of this. What does this allow you to do that is currently not possible? This PR is also missing a test. |
|
I am going to close this one as per previous comment since there was no follow-up. |
Provide an interface
GestureDetailsWithPositionas a common interface between gesture details that provides position.Fixes #101530
Pre-launch Checklist
///).