Skip to content

Provide common interface for gestures that provide position#101665

Closed
mateusfccp wants to merge 2 commits into
flutter:masterfrom
mateusfccp:abstract_over_gesture_details_that_share_position_properties
Closed

Provide common interface for gestures that provide position#101665
mateusfccp wants to merge 2 commits into
flutter:masterfrom
mateusfccp:abstract_over_gesture_details_that_share_position_properties

Conversation

@mateusfccp

@mateusfccp mateusfccp commented Apr 10, 2022

Copy link
Copy Markdown
Contributor

Provide an interface GestureDetailsWithPosition as a common interface between gesture details that provides position.

Fixes #101530

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 10, 2022
@mateusfccp mateusfccp marked this pull request as ready for review April 10, 2022 14:00
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@mateusfccp

Copy link
Copy Markdown
Contributor Author

I don't know if this kind of change is test-exempt, I can't think of any tests that could be added, as it's a simple change in the type system...

@HansMuller HansMuller requested a review from goderbauer April 15, 2022 21:53
@goderbauer

Copy link
Copy Markdown
Member

I am not super-convinced of the benefits of this. What does this allow you to do that is currently not possible?

This PR is also missing a test.

@goderbauer

Copy link
Copy Markdown
Member

I am going to close this one as per previous comment since there was no follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generalize gesture details that concerns cartesian positioning in a common interface

2 participants