-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/plugins
#6591Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: webviewThe WebView pluginThe WebView pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specifically
Description
The following autogenerated mock method:
void requestFullscreen() =>
super.noSuchMethod(Invocation.method(#requestFullscreen, []),
returnValueForMissingStub: null);Has had its API recently changed, in dart:html, here)
It is causing build errors in the latest master like so:
org-dartlang-app:///webview_flutter_web_test.mocks.dart:933:8: Error: The return type of the method 'MockIFrameElement.requestFullscreen' is 'void', which does not match the return type, 'Future<void>', of the overridden method, 'Element.requestFullscreen'.
- 'Future' is from 'dart:async'.
Change to a subtype of 'Future<void>'.
void requestFullscreen() =>
^
org-dartlang-sdk:///dart-sdk/lib/html/dart2js/html_dart2js.dart: Context: This is the overridden method ('requestFullscreen').
org-dartlang-app:///webview_flutter_web_test.mocks.dart:933:8: Error: The method 'MockIFrameElement.requestFullscreen' has fewer positional arguments than those of overridden method 'Element.requestFullscreen'.
void requestFullscreen() =>
^
org-dartlang-sdk:///dart-sdk/lib/html/dart2js/html_dart2js.dart: Context: This is the overridden method ('requestFullscreen').
Failed to compile
Regenerate the webview_flutter_web_test.mocks.dart once the above Dart commit makes it to Flutter stable.
(Clean this)
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listp: webviewThe WebView pluginThe WebView pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-webWeb applications specificallyWeb applications specifically