-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/engine
#28891Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)customer: money (g3)engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.perf: memoryPerformance issues related to memoryPerformance issues related to memoryperf: speedPerformance issues related to (mostly rendering) speedPerformance issues related to (mostly rendering) speedplatform-androidAndroid applications specificallyAndroid applications specifically
Description
Specifically, here:
Whereas we only notify the application code if the memory level is RUNNING_LOW, which also seems like a bug.
It seems like we should also notify the application if we have RUNNING_CRITICAL or if it's the LOW/CRITICAL for not running.
It also seems like we should check at least for RUNNING_LOW/RUNNING_CRITICAL before telling the Dart VM to potentially GC. On lower end devices, I've observed this particular codepath triggering a 250ms during the critical path to first frame.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)customer: money (g3)engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.perf: memoryPerformance issues related to memoryPerformance issues related to memoryperf: speedPerformance issues related to (mostly rendering) speedPerformance issues related to (mostly rendering) speedplatform-androidAndroid applications specificallyAndroid applications specifically