-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.platform-webWeb applications specificallyWeb applications specificallyteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
This PR broke some framework tests: flutter/engine#24903. For example, running the following command with the PR will consistently fail, as expected:
flutter --local-engine=host_debug_unopt test --platform=chrome test/material/tabs_test.dart
However, that PR was green on LUCI both pre- and post-submit:
The tabs_test.dart did run as part of the LUCI build with the following command and it does attempt to use a local engine build, but it didn't fail (complete log):
../../bin/flutter test -v --platform=chrome --web-renderer=html --sound-null-safety \
--local-engine /b/s/w/ir/cache/builder/src/out/host_debug_unopt \
test/cupertino/theme_test.dart \
test/material/flexible_space_bar_collapse_mode_test.dart \
test/widgets/box_decoration_test.dart \
test/widgets/performance_overlay_test.dart \
test/widgets/scroll_physics_test.dart \
test/scheduler/scheduler_test.dart \
test/widgets/animated_size_test.dart \
test/material/tooltip_test.dart \
test/material/input_decorator_test.dart \
test/widgets/default_text_style_test.dart \
test/rendering/non_render_object_root_test.dart \
test/widgets/multichild_test.dart \
test/material/user_accounts_drawer_header_test.dart \
test/widgets/slivers_appbar_pinned_test.dart \
test/widgets/ensure_visible_test.dart \
test/widgets/range_maintaining_scroll_physics_test.dart \
test/material/flexible_space_bar_stretch_mode_test.dart \
test/animation/futures_test.dart \
test/widgets/physical_model_test.dart \
test/material/typography_test.dart \
test/widgets/transformed_scrollable_test.dart \
test/material/flat_button_test.dart \
test/material/expansion_panel_test.dart \
test/widgets/scroll_notification_test.dart \
test/widgets/init_state_test.dart \
test/gestures/velocity_tracker_test.dart \
test/painting/shape_decoration_test.dart \
test/gestures/double_tap_test.dart \
test/material/data_table_theme_test.dart \
test/gestures/tap_test.dart \
test/services/text_formatter_test.dart \
test/widgets/async_test.dart \
test/widgets/aspect_ratio_test.dart \
test/foundation/assertions_test.dart \
test/rendering/box_test.dart \
test/material/about_test.dart \
test/widgets/sliver_visibility_test.dart \
test/rendering/flex_test.dart \
test/material/expansion_tile_test.dart \
test/painting/gradient_test.dart \
test/widgets/stateful_component_test.dart \
test/material/snack_bar_test.dart \
test/cupertino/nav_bar_transition_test.dart \
test/rendering/first_frame_test.dart \
test/animation/animation_controller_test.dart \
test/foundation/licenses_test.dart \
test/widgets/visibility_test.dart \
test/cupertino/debug_test.dart \
test/gestures/drag_test.dart \
test/widgets/list_view_viewporting_test.dart \
test/rendering/viewport_caching_test.dart \
test/painting/paint_image_test.dart \
test/material/tabs_test.dart \
test/material/page_selector_test.dart \
test/painting/stadium_border_test.dart \
test/material/text_selection_toolbar_test.dart \
test/widgets/set_state_4_test.dart \
test/rendering/debug_test.dart \
test/material/dropdown_test.dart \
test/widgets/grid_view_layout_test.dart \
test/rendering/platform_view_test.dart \
test/material/snack_bar_theme_test.dart \
test/widgets/notification_test.dart \
test/widgets/image_icon_test.dart \
test/widgets/run_app_async_test.dart \
test/animation/tween_test.dart \
test/widgets/image_test.dart \
test/widgets/scrollable_animations_test.dart \
test/widgets/animated_align_test.dart \
test/material/page_test.dart \
test/widgets/editable_text_cursor_test.dart \
test/widgets/dispose_ancestor_lookup_test.dart \
test/physics/utils_test.dart \
test/widgets/slivers_appbar_scrolling_test.dart \
test/widgets/mouse_region_test.dart \
test/widgets/focus_scope_test.dart \
test/widgets/semantics_11_test.dart \
test/gestures/transformed_scale_test.dart \
test/material/ink_paint_test.dart \
test/painting/image_decoder_test.dart \
test/widgets/global_keys_duplicated_test.dart \
test/material/data_table_test.dart \
test/material/scrollbar_test.dart \
test/services/system_sound_test.dart
Metadata
Metadata
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressionc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.platform-webWeb applications specificallyWeb applications specificallyteam-infraOwned by Infrastructure teamOwned by Infrastructure teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
