Skip to content

Dart roll triggers new analyzer hints in google_sign_in_web #76625

@zanderso

Description

@zanderso

On the roll here #76620

That includes the Dart roll here flutter/engine#24554

There are new analyzer "info" messages about unused elements, e.g. the class _RequestOptions here:

https://github.com/flutter/plugins/blob/master/packages/google_sign_in/google_sign_in_web/lib/src/generated/gapi.dart#L228

There are a number of related-looking commits in the Dart roll, e.g.: https://dart.googlesource.com/sdk.git/+/b7849ab93396d4f5a5b9f2a9747620ee80bfc4d1.

We need to either adjust the analyzer to restore the previous behavior, or fix the code generator that generates the gapi.dart file above to suppress the warning.

P0 since this blocks the Engine -> Framework roll.

@srawlins @stuartmorgan

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressiondependency: dartDart team may need to help usp: google_sign_inThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions