-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Closed
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
Description
Both @cyanglaz and I have tried to generate the golden images for flutter/engine#17915. Although our locally generated images can pass the test locally, they fail in LUCI bots. It turns out that only images generated from @blasten 's Mac can let LUCI bots pass the test. According to Emmanuel, the golden images generated by me has no pixel difference with his images. But the test with my images somehow failed in his Mac and LUCI. This suggest that the pixel comparison in the test might be problematic.
cyanglaz
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly passengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.