-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.dependency: skiaSkia team may need to help usSkia team may need to help usframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure teamOwned by Infrastructure teamwill affect goldensChanges to golden filesChanges to golden files
Description
Currently Gold does not support branching.
This could potentially lead to issues like
- master/realease-branch-x being out of sync with one another
- golden files not being checked in from a hotfix change applied to release branch
- multiple sources of correct golden files stemming from different branches
This will also affect the flutter/cocoon based flutter-gold check that all framework tests rely on in pre-submit tests. Individual golden file tests will not fail in test shards anymore, so without the flutter-gold check the golden file tests are basically ignored.
Metadata
Metadata
Assignees
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.dependency: skiaSkia team may need to help usSkia team may need to help usframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure teamOwned by Infrastructure teamwill affect goldensChanges to golden filesChanges to golden files