Skip to content

download_goldctl.sh should retry if the depot_tools clone fails #44786

@jmagman

Description

@jmagman

Use case

It looks like sometimes cloning depot_tools fails on Cirrus (network issues?).

ulimit -S -n 2048
./dev/bots/download_goldctl.sh
Cloning into './depot_tools'...
error: RPC failed; curl 56 LibreSSL SSL_read: SSL_ERROR_SYSCALL, errno 60
fatal: the remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
./dev/bots/download_goldctl.sh: line 4: cd: depot_tools: No such file or directory
./dev/bots/download_goldctl.sh: line 6: ./cipd: No such file or directory

Exit status: 127

https://cirrus-ci.com/task/5949937388355584?command=main#L0

Proposal

Consider a sleep and retry as is done in a few other tests. With increased control logic, it may be a good time to migrate to a dart test.

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.team-infraOwned by Infrastructure team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions