-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Closed
Copy link
Labels
p: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.waiting for PR to land (fixed)A fix is in flightA fix is in flight
Description
When testing google_sign_in, I found some users with a Profile Image URL similar to this:
https://lh3.googleusercontent.com/a-/AAuE7mA88dkKFp41ksoqhET-ppaK-nGCTb1omEvo2Hxw
When the GoogleUserCircleAvatar attempts to add sizing/cropping information to the URL (s110-c), it ends like this:
https://lh3.googleusercontent.com/a-/s110-c/AAuE7mA88dkKFp41ksoqhET-ppaK-nGCTb1omEvo2Hxw
Which always yields a 404; because the right URL to resize that image needs to be this:
https://lh3.googleusercontent.com/a-/AAuE7mA88dkKFp41ksoqhET-ppaK-nGCTb1omEvo2Hxw=s110-c
Steps to Reproduce
- Sign in with the
exampleapp with a user account that has a profile picture.
- Expected: After some time, the profile image fades in
- Actual: The profile image never loads.
Target Platform: All, I debugged this on Android
Target OS version/browser: Any
Devices: All
Logs
I/flutter ( 4085): Another exception was thrown: HTTP request failed, statusCode: 404, https://lh3.googleusercontent.com/a-/s110-c/AAuE7mA88dkKFp41ksoqhET-ppaK-nGCTb1omEvo2Hxw
ditman and CaseyHillers
Metadata
Metadata
Assignees
Labels
p: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.waiting for PR to land (fixed)A fix is in flightA fix is in flight