-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: releaseChallenges faced when attempting to productionize an appChallenges faced when attempting to productionize an appc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
Description
During security review we were asked to make sure our C++ compile flags for Release configs use the following:
Compile-time flags: -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-all -fPIE -Wa,--noexecstack -Wformat -Wformat-security
Link-time flags: -pie -Wl,-z,relro,-z,now
This is non-urgent, but we should address for 1.0.
FYI @abarth @chinmaygarde
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: releaseChallenges faced when attempting to productionize an appChallenges faced when attempting to productionize an appc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.