-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flightA fix is in flight
Description
We use the term "modal" to mean two related but not identical things:
- Routes that go into the navigator's "modal" list (as opposed to the ephemeral list); this is exposed in particular on the NavigatorObserver "didPushModal" method. These could be ModalRoute subclasses but need not be (in particular, StateRoute isn't).
- Routes that subclass ModalRoutes (which could be modal or ephemeral).
We should clean that up.
Metadata
Metadata
Assignees
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flightA fix is in flight