-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
flutter/engine
#11034Labels
engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
Description
licenses.sh crawls each top-level directory in the buildroot looking for changes, gathers them all up, reports the diff for the first changed folder... then exits, throwing away the diffs gathered for all later folders.
For some of my recent run-ins with this script I've had to run it 3-4 times, applying diffs each time, to get all the output. In some cases I've had to do that on bots (because of the issues with running it on non-Linux machines), which was not only painful for me, but wasted bot resources as well (especially since each run also ran the whole suite of CI tests again even though I didn't care about those).
It seems like it would be much better to report all the diffs before exiting, rather than the first one.
Metadata
Metadata
Assignees
Labels
engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.