-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
c: crashStack traces logged to the consoleStack traces logged to the consolep: firebaseFirebase pluginsFirebase pluginsp: firebase_ml_visionThe Firebase ML Vision pluginThe Firebase ML Vision pluginp: firebase_performanceFirebase Performance pluginFirebase Performance pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.
Description
When calling invokeMethod, some plugins use a method name along the lines of $ClassName#MethodName. When trying to obfuscate the dart code in a flutter app, this may inadvertently change the class names on the dart side, but not the native side.
For example invokeMethod('$Adder#add') would be replaced with invokeMethod('$zza#add').
I'm not sure of all plugins that would be affected by this, but firebase_ml_vision and firebase_performance use this format.
This could be solved by just removing the $ in front of the method name.
Related comment: flutter/plugins@90ed52d#commitcomment-34121822
axel-op
Metadata
Metadata
Assignees
Labels
c: crashStack traces logged to the consoleStack traces logged to the consolep: firebaseFirebase pluginsFirebase pluginsp: firebase_ml_visionThe Firebase ML Vision pluginThe Firebase ML Vision pluginp: firebase_performanceFirebase Performance pluginFirebase Performance pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.