Skip to content

Fix the disabled Mutator tests #35338

@cyanglaz

Description

@cyanglaz

Some mutator tests are failing with

Note: Google Test filter = -PerformanceOverlayLayer.Gold
[==========] Running 22 tests from 5 test suites.
[----------] Global test environment set-up.
[----------] 1 test from PhysicalShapeLayer
[ RUN      ] PhysicalShapeLayer.TotalElevation
[       OK ] PhysicalShapeLayer.TotalElevation (1 ms)
[----------] 1 test from PhysicalShapeLayer (1 ms total)

[----------] 5 tests from MatrixDecomposition
[ RUN      ] MatrixDecomposition.Rotation
[       OK ] MatrixDecomposition.Rotation (0 ms)
[ RUN      ] MatrixDecomposition.Scale
[       OK ] MatrixDecomposition.Scale (0 ms)
[ RUN      ] MatrixDecomposition.Translate
[       OK ] MatrixDecomposition.Translate (0 ms)
[ RUN      ] MatrixDecomposition.Combination
[       OK ] MatrixDecomposition.Combination (0 ms)
[ RUN      ] MatrixDecomposition.ScaleFloatError
[       OK ] MatrixDecomposition.ScaleFloatError (3753 ms)
[----------] 5 tests from MatrixDecomposition (3753 ms total)

[----------] 8 tests from MutatorsStack
[ RUN      ] MutatorsStack.Initialization
[       OK ] MutatorsStack.Initialization (0 ms)
[ RUN      ] MutatorsStack.CopyConstructor
../../flutter/flow/mutators_stack_unittests.cc:20: Failure
Value of: copy == stack
  Actual: false
Expected: true
[  FAILED  ] MutatorsStack.CopyConstructor (0 ms)
[ RUN      ] MutatorsStack.PushClipRect
../../flutter/flow/mutators_stack_unittests.cc:29: Failure
Value of: iter->get()->rect() == rect
  Actual: false
Expected: true
[  FAILED  ] MutatorsStack.PushClipRect (0 ms)
[ RUN      ] MutatorsStack.PushClipRRect
[       OK ] MutatorsStack.PushClipRRect (0 ms)
[ RUN      ] MutatorsStack.PushTransform
[       OK ] MutatorsStack.PushTransform (0 ms)
[ RUN      ] MutatorsStack.Pop
[       OK ] MutatorsStack.Pop (0 ms)
[ RUN      ] MutatorsStack.Traversal
../../flutter/flow/mutators_stack_unittests.cc:77: Failure
Value of: iter->get()->rect() == rect
  Actual: false
Expected: true
[  FAILED  ] MutatorsStack.Traversal (0 ms)
[ RUN      ] MutatorsStack.Equality
[       OK ] MutatorsStack.Equality (0 ms)
[----------] 8 tests from MutatorsStack (0 ms total)

[----------] 4 tests from Mutator
[ RUN      ] Mutator.Initialization
[       OK ] Mutator.Initialization (0 ms)
[ RUN      ] Mutator.CopyConstructor
[       OK ] Mutator.CopyConstructor (0 ms)
[ RUN      ] Mutator.Equality
[       OK ] Mutator.Equality (0 ms)
[ RUN      ] Mutator.UnEquality
[       OK ] Mutator.UnEquality (0 ms)
[----------] 4 tests from Mutator (0 ms total)

[----------] 4 tests from RasterCache
[ RUN      ] RasterCache.SimpleInitialization
[       OK ] RasterCache.SimpleInitialization (0 ms)
[ RUN      ] RasterCache.ThresholdIsRespected
[       OK ] RasterCache.ThresholdIsRespected (1 ms)
[ RUN      ] RasterCache.ThresholdIsRespectedWhenZero
[       OK ] RasterCache.ThresholdIsRespectedWhenZero (0 ms)
[ RUN      ] RasterCache.SweepsRemoveUnusedFrames
[       OK ] RasterCache.SweepsRemoveUnusedFrames (1 ms)
[----------] 4 tests from RasterCache (2 ms total)

[----------] Global test environment tear-down
[==========] 22 tests from 5 test suites ran. (3756 ms total)
[  PASSED  ] 19 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] MutatorsStack.CopyConstructor
[  FAILED  ] MutatorsStack.PushClipRect
[  FAILED  ] MutatorsStack.Traversal

 3 FAILED TESTS

Execution detail:

/b/s/w/ir/k/src/out/host_debug_unopt/flow_unittests '--gtest_filter=-PerformanceOverlayLayer.Gold'
in dir /b/s/w/ir/k/src/out/host_debug_unopt
full environment:
  Apple_PubSub_Socket_Render: /private/tmp/com.apple.launchd.8EIMZnE5eZ/Render
  BOTO_CONFIG: /b/s/w/ir/tmp/gsutil-task/.boto
  BUILDBUCKET_EXPERIMENTAL: FALSE
  CIPD_CACHE_DIR: /b/s/cipd_cache/cache
  CIPD_PROTOCOL: v2
  DEVSHELL_CLIENT_PORT: 49956
  DOCKER_CONFIG: /b/s/w/ir/tmp/docker-cfg-task
  DOCKER_TMPDIR: /b/s/w/ir/tmp/docker-tmp-task
  GIT_CONFIG_NOSYSTEM: 1
  GIT_TERMINAL_PROMPT: 0
  GOMA_DIR: /b/s/w/ir/cache/goma/client
  HOME: /Users/chrome-bot
  INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git-home-task
  LOGDOG_COORDINATOR_HOST: logs.chromium.org
  LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8909296187442826064
  LOGDOG_STREAM_PROJECT: flutter
  LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock
  LOGNAME: chrome-bot
  LUCI_CONTEXT: /b/s/w/ir/tmp/luci_context.473116248
  MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t
  NO_GCE_CHECK: False
  PATH: /b/s/w/ir/k/src/third_party/dart/tools/sdks/dart-sdk/bin:/b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/usr/local/git/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
  PWD: /b/s/w/ir/k
  PYTHONIOENCODING: UTF-8
  PYTHONUNBUFFERED: 1
  SHELL: /bin/bash
  SHLVL: 1
  SSH_AUTH_SOCK: /private/tmp/com.apple.launchd.iBrB8oqYS3/Listeners
  SWARMING_BOT_ID: build270-m9
  SWARMING_HEADLESS: 1
  SWARMING_SERVER: https://chromium-swarm.appspot.com
  SWARMING_TASK_ID: 45bd25286e55fe11
  TEMP: /b/s/w/ir/tmp/t
  TEMPDIR: /b/s/w/ir/tmp/t
  TMP: /b/s/w/ir/tmp/t
  TMPDIR: /b/s/w/ir/tmp/t
  USER: chrome-bot
  VERSIONER_PYTHON_PREFER_32_BIT: no
  VERSIONER_PYTHON_VERSION: 2.7
  VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython
  XPC_FLAGS: 0x0
  XPC_SERVICE_NAME: 0
  _: /b/s/w/ir/cipd_bin_packages/vpython
  __CF_USER_TEXT_ENCODING: 0x1F4:0x0:0x0

Step had exit code: 1 (a.k.a. 0x100000001)

I disabled them at flutter/engine#9608

Need to figure out the failing reason and re-enable them.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions