-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Closed
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsd: wikiFlutter or engine wikisFlutter or engine wikisframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
There should be a check to prevent the creation of duplicate file names for golden file testing.
Another possibility is the use of a more structure naming convention that prevent duplication like #33804, where two tests in the cupertino library and two tests in the material library were identical, causing conflict in Skia Gold. This however would require replacing every file in the current flutter/goldens repo, and establishing a new baseline for all platforms in Skia Gold.
When #33688 lands, images will not be siloed into library specific folders like flutter/goldens, making it easier to run into collisions such as these.
- Wiki will need to be updated as well
Metadata
Metadata
Assignees
Labels
a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsd: wikiFlutter or engine wikisFlutter or engine wikisframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.