Skip to content

Check for duplicate Golden File names #33806

@Piinks

Description

@Piinks

There should be a check to prevent the creation of duplicate file names for golden file testing.

Another possibility is the use of a more structure naming convention that prevent duplication like #33804, where two tests in the cupertino library and two tests in the material library were identical, causing conflict in Skia Gold. This however would require replacing every file in the current flutter/goldens repo, and establishing a new baseline for all platforms in Skia Gold.

When #33688 lands, images will not be siloed into library specific folders like flutter/goldens, making it easier to run into collisions such as these.

  • Wiki will need to be updated as well

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our testsd: wikiFlutter or engine wikisframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions