BottomNavigationBar does not respect theme in shifting mode #27753
Description
BottomNavigationBar appears to stop respecting the app theme when it goes from a fixed mode to a shifting mode.
Repro steps:
- Start with a
BottomNavigationBarthat has 3 tabs, in an app with a light theme and dark icons:
BottomNavigationBar(
currentIndex: _activeTabIndex,
items: [
BottomNavigationBarItem(
icon: Icon(Icons.play_circle_filled),
title: Text('Demo'),
),
BottomNavigationBarItem(
icon: Icon(Icons.style),
title: Text('Inspiration'),
),
BottomNavigationBarItem(
icon: Icon(Icons.accessibility),
title: Text('Anatomy'),
),
]
),- Add a 4th tab. This automatically changes the bar to
shiftingmode. Notice that the background of the bar remains light, but now the icons go from dark to light which makes them barely visible:
BottomNavigationBar(
currentIndex: _activeTabIndex,
items: [
BottomNavigationBarItem(
icon: Icon(Icons.play_circle_filled),
title: Text('Demo'),
),
BottomNavigationBarItem(
icon: Icon(Icons.style),
title: Text('Inspiration'),
),
BottomNavigationBarItem(
icon: Icon(Icons.accessibility),
title: Text('Anatomy'),
),
BottomNavigationBarItem(
icon: Icon(Icons.compare),
title: Text('Catalog'),
),
]
),- Explicitly change the
BottomNavigationBarto use thefixedmode. Notice that the icons regain their correct, dark tint:
BottomNavigationBar(
currentIndex: _activeTabIndex,
type: BottomNavigationBarType.fixed,
items: [
BottomNavigationBarItem(
icon: Icon(Icons.play_circle_filled),
title: Text('Demo'),
),
BottomNavigationBarItem(
icon: Icon(Icons.style),
title: Text('Inspiration'),
),
BottomNavigationBarItem(
icon: Icon(Icons.accessibility),
title: Text('Anatomy'),
),
BottomNavigationBarItem(
icon: Icon(Icons.compare),
title: Text('Catalog'),
),
]
),Flutter Doctor:
Flutter (Channel master, v1.1.6-pre.27, on Mac OS X 10.13.6 17G65, locale en-US)